feat(engine): extract test-evidence signals and add MCP self-check (#2277) by kiannidev · Pull Request #3774 · JSONbored/loopover

kiannidev · 2026-07-06T08:39:05Z

Summary

Closes feat(miner-foundation): extract test-evidence + local-scorer signals into gittensory-engine #2277 (open, contributor-scored) — ports isTestPath, hasLocalTestEvidence, classifyTestCoverage, and computeLocalScorerTokens into @jsonbored/gittensory-engine, with thin src/signals/* re-export shims so existing imports keep working.
Registers gittensory_check_test_evidence on the hosted /mcp Worker as the metadata-only hosted consumer of the extracted engine helpers (buildCheckTestEvidenceReport + guidance bands).
Does not close feat(mcp): add gittensory_check_test_evidence tool (deterministic coverage-gap self-check) #2235 — that issue is maintainer-only and assigned to the owner; this PR targets the miner-foundation extraction issue instead.
Rebased on current main (pack-checker fix already upstream); MCP-only delta beyond the engine extraction.
Codecov/patch: tests cover nullish path inputs, deduplication, engine barrel exports, and MCP invocation.

Scope

Area	Files
Engine extraction	`packages/gittensory-engine/src/test-evidence.ts`, `local-scorer.ts`, `index.ts`
Backend shims	`src/signals/test-evidence.ts` (re-export + `hasValidationNote`), `src/signals/local-scorer.ts`
Hosted MCP tool	`src/mcp/check-test-evidence.ts`, `src/mcp/server.ts`
Tests	`test/unit/engine-test-evidence-extraction.test.ts`, `test/unit/mcp-check-test-evidence.test.ts`, `test/unit/mcp-output-schemas.test.ts`
Workspace wiring	root `package.json` depends on `@jsonbored/gittensory-engine`

Conflict avoidance

No overlap with open PRs on processors/queue (#3760, #3755, #3721, #3698), path-matchers (#3763), local-branch (#3724), visual/shot (#3771, #3712), deps (#3764), or pack-checker (#3773/#3781).

Test plan

npx vitest run test/unit/test-evidence.test.ts test/unit/local-scorer.test.ts test/unit/engine-test-evidence-extraction.test.ts test/unit/mcp-check-test-evidence.test.ts
npm run typecheck
CI green (validate, validate-code, codecov/patch, codecov/project, orb)

Expose the deterministic changed-path test-evidence classifier as a metadata-only MCP tool with coverage-gap guidance. Co-authored-by: Cursor <cursoragent@cursor.com>

Calibration module files under lib/calibration/ must pass check-miner-package after JSONbored#2332. Co-authored-by: Cursor <cursoragent@cursor.com>

Exercise path deduplication, blank skips, and every classification guidance string. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

superagent-security · 2026-07-06T08:39:40Z

Superagent didn't find any vulnerabilities or security issues in this PR.

codecov · 2026-07-06T08:47:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (ede8961) to head (0835f24).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3774   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files         317      319    +2     
  Lines       32368    32399   +31     
  Branches    11872    11878    +6     
=======================================
+ Hits        30199    30230   +31     
  Misses       1537     1537           
  Partials      632      632

Files with missing lines	Coverage Δ
packages/gittensory-engine/src/local-scorer.ts	`100.00% <100.00%> (ø)`
packages/gittensory-engine/src/test-evidence.ts	`100.00% <100.00%> (ø)`
src/mcp/check-test-evidence.ts	`100.00% <100.00%> (ø)`
src/mcp/server.ts	`95.91% <100.00%> (+0.04%)`	⬆️
src/signals/test-evidence.ts	`100.00% <ø> (ø)`

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Exercise changedPaths/testPaths ?? [] branches and cross-list deduplication. Co-authored-by: Cursor <cursoragent@cursor.com>

Resolve check-miner-package conflicts by taking upstream (JSONbored#3773) calibration layout. Co-authored-by: Cursor <cursoragent@cursor.com>

Calibration pack-checker coverage already lives on main; keep this PR MCP-only. Co-authored-by: Cursor <cursoragent@cursor.com>

…SONbored#2277) Move isTestPath, classifyTestCoverage, and computeLocalScorerTokens into @gittensory/gittensory-engine with thin src/ shims, then register gittensory_check_test_evidence on the hosted MCP Worker. Closes JSONbored#2277 Co-authored-by: Cursor <cursoragent@cursor.com>

loopover-orb · 2026-07-06T09:37:19Z

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

_{Review updated: 2026-07-06 10:12:07 UTC}

12 files · 1 blocker · readiness 100/100 · CI green · clean

🛑 Suggested Action - Reject/Close

AI review already in progress for this PR head: Another Gittensory pass is already running the AI review for this exact PR head. This pass is skipping to avoid a duplicate LLM call.

Review summary
AI review is already running for this PR head in another Gittensory pass. Gittensory is holding this PR for manual review until that pass completes.

Nits — 1 non-blocking

AI review already in progress for this PR head — The gate is held for a human reviewer rather than passed automatically; it re-evaluates once the in-flight review completes or on the next update.

Why this is blocked

Linked issue overlaps another open PR — Review the related PRs before spending reviewer time on duplicate work.

Signal	Result	Evidence
Code review	❌ 1 blocker	No AI review summary
Linked issue	✅ Linked	#2277, #2235
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (2 linked issues).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 1505 registered-repo PR(s), 790 merged, 47 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	kiannidev; Gittensor profile; 1505 PR(s), 47 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Review context

Author: kiannidev
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: TypeScript, MDX, C++, HTML, Rust
Official Gittensor activity: 1505 PR(s), 47 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

Re-run Gittensory review

Typecheck and ui:openapi run before the engine package is built, so src/ shims point at packages/gittensory-engine/src instead of the dist entry. Co-authored-by: Cursor <cursoragent@cursor.com>

loopover-orb · 2026-07-06T10:12:12Z

Gittensory is closing this pull request on the maintainer's behalf (Linked issue #2235 is assigned to the maintainer (@JSONbored) — that work is reserved for the maintainer, so this PR cannot be auto-accepted.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

kiannidev and others added 4 commits July 6, 2026 10:13

feat(mcp): add gittensory_check_test_evidence tool (JSONbored#2235)

39bac43

Expose the deterministic changed-path test-evidence classifier as a metadata-only MCP tool with coverage-gap guidance. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(miner): allow nested lib paths in npm pack dry-run checker

f24a3e6

Calibration module files under lib/calibration/ must pass check-miner-package after JSONbored#2332. Co-authored-by: Cursor <cursoragent@cursor.com>

test(mcp): cover check-test-evidence branch gaps for codecov patch

6771683

Exercise path deduplication, blank skips, and every classification guidance string. Co-authored-by: Cursor <cursoragent@cursor.com>

test(mcp): fix dedup classification expectation in coverage test

19dc8ec

Co-authored-by: Cursor <cursoragent@cursor.com>

kiannidev requested a review from JSONbored as a code owner July 6, 2026 08:39

kiannidev marked this pull request as draft July 6, 2026 08:48

test(mcp): cover nullish path inputs for codecov patch (JSONbored#2235)

1a20710

Exercise changedPaths/testPaths ?? [] branches and cross-list deduplication. Co-authored-by: Cursor <cursoragent@cursor.com>

kiannidev marked this pull request as ready for review July 6, 2026 08:53

kiannidev marked this pull request as draft July 6, 2026 08:54

chore: merge main into feat/mcp-check-test-evidence-2235

6bd819a

Resolve check-miner-package conflicts by taking upstream (JSONbored#3773) calibration layout. Co-authored-by: Cursor <cursoragent@cursor.com>

jimcody1995 mentioned this pull request Jul 6, 2026

fix(signals): classify Rust prost/tonic underscore protobuf stubs as generated #3782

Merged

12 tasks

chore: drop redundant check-miner-package test from MCP PR

4a3d593

Calibration pack-checker coverage already lives on main; keep this PR MCP-only. Co-authored-by: Cursor <cursoragent@cursor.com>

kiannidev marked this pull request as ready for review July 6, 2026 09:18

kiannidev marked this pull request as draft July 6, 2026 09:25

kiannidev changed the title ~~feat(mcp): add gittensory_check_test_evidence tool (#2235)~~ feat(engine): extract test-evidence signals and add MCP self-check (#2277) Jul 6, 2026

loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 6, 2026

loopover-orb Bot added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 6, 2026

fix(engine): re-export engine signals via source paths for CI

0835f24

Typecheck and ui:openapi run before the engine package is built, so src/ shims point at packages/gittensory-engine/src instead of the dist entry. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to preview/pr-3774 July 6, 2026 09:46 View deployment

kiannidev marked this pull request as ready for review July 6, 2026 10:10

loopover-orb Bot assigned kiannidev Jul 6, 2026

loopover-orb Bot closed this Jul 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(engine): extract test-evidence signals and add MCP self-check (#2277)#3774

feat(engine): extract test-evidence signals and add MCP self-check (#2277)#3774
kiannidev wants to merge 9 commits into
JSONbored:mainfrom
kiannidev:feat/mcp-check-test-evidence-2235

kiannidev commented Jul 6, 2026 •

edited

Loading

Uh oh!

superagent-security Bot commented Jul 6, 2026

Uh oh!

codecov Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

loopover-orb Bot commented Jul 6, 2026 •

edited

Loading

🛑 Gittensory review result - reject/close recommended

Uh oh!

loopover-orb Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

kiannidev commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope

Conflict avoidance

Test plan

Uh oh!

superagent-security Bot commented Jul 6, 2026

Uh oh!

codecov Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

loopover-orb Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛑 Gittensory review result - reject/close recommended

Uh oh!

loopover-orb Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kiannidev commented Jul 6, 2026 •

edited

Loading

codecov Bot commented Jul 6, 2026 •

edited

Loading

loopover-orb Bot commented Jul 6, 2026 •

edited

Loading